Skip to content

Add transfer ownership unit tests#1894

Merged
susnux merged 1 commit intomainfrom
enh/missing-unit-tests
Apr 14, 2024
Merged

Add transfer ownership unit tests#1894
susnux merged 1 commit intomainfrom
enh/missing-unit-tests

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jan 24, 2024

fix #1830

@hamza221 hamza221 added the 3. to review Waiting for reviews label Jan 24, 2024
@hamza221 hamza221 requested a review from Chartman123 January 24, 2024 18:55
@hamza221 hamza221 self-assigned this Jan 24, 2024
@hamza221 hamza221 force-pushed the enh/missing-unit-tests branch from 21c2ba9 to b2ecaf7 Compare January 24, 2024 18:56
@susnux
Copy link
Collaborator

susnux commented Jan 24, 2024 

There was 1 error:

1) OCA\Forms\Tests\Unit\Controller\ApiControllerTest::testTransferOwner
OCP\AppFramework\OCS\OCSForbiddenException: This form is not owned by the current user

/home/runner/work/forms/forms/apps/forms/lib/Controller/ApiController.php:386
/home/runner/work/forms/forms/apps/forms/tests/Unit/Controller/ApiControllerTest.php:932

@Chartman123 Chartman123 modified the milestones: 4.1, 4.2 Jan 24, 2024
@Chartman123 Chartman123 force-pushed the enh/missing-unit-tests branch from b2ecaf7 to 7614385 Compare April 13, 2024 17:48
@Chartman123 Chartman123 marked this pull request as draft April 14, 2024 08:58
@Chartman123 Chartman123 force-pushed the enh/missing-unit-tests branch from 6c03d22 to 7614385 Compare April 14, 2024 09:01
@Chartman123
Copy link
Collaborator

Chartman123 commented Apr 14, 2024 

There was 1 error:

1) OCA\Forms\Tests\Unit\Controller\ApiControllerTest::testTransferOwner
OCP\AppFramework\OCS\OCSForbiddenException: This form is not owned by the current user

/home/runner/work/forms/forms/apps/forms/lib/Controller/ApiController.php:386
/home/runner/work/forms/forms/apps/forms/tests/Unit/Controller/ApiControllerTest.php:932

FormMapper wasn't set to respond with the $form set in the tests.

@Chartman123 Chartman123 force-pushed the enh/missing-unit-tests branch from 8f5b68c to ffce0a3 Compare April 14, 2024 13:30
@hamza221 @Chartman123
Add transfer ownership unit tests
02530b0 
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
@Chartman123 Chartman123 force-pushed the enh/missing-unit-tests branch from ffce0a3 to 02530b0 Compare April 14, 2024 13:32
@Chartman123 Chartman123 marked this pull request as ready for review April 14, 2024 13:34
@Chartman123 Chartman123 requested a review from susnux April 14, 2024 13:34
@susnux susnux merged commit b49f0c5 into main Apr 14, 2024
@susnux susnux deleted the enh/missing-unit-tests branch April 14, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@Chartman123 Chartman123 Chartman123 approved these changes

Assignees

@hamza221 hamza221

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

Add missing tests for transfer of ownership

3 participants

@hamza221 @susnux @Chartman123