Skip to content

Render markdown files directly in public share#48

Merged
MorrisJobke merged 1 commit intomasterfrom
markdown-public-share-preview
Jul 21, 2017
Merged

Render markdown files directly in public share#48
MorrisJobke merged 1 commit intomasterfrom
markdown-public-share-preview

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Jul 20, 2017

Renders markdown files for single share pages directly inline and uses a readable styling (instead of the squared preview image for the text file).

Looks like this then:

bildschirmfoto 2017-07-21 um 00 34 46
bildschirmfoto 2017-07-21 um 00 34 54
bildschirmfoto 2017-07-21 um 00 03 31

In case the loading of the preview failed it will show the default image preview as before.

@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Jul 20, 2017
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Jul 20, 2017 •
edited
Loading

BTW: Heavily inspired by https://app.simplenote.com/publish/DSLBYB 🙈 I have seen this and wanted it too 😆

@rullzer
Copy link
Member

rullzer commented Jul 21, 2017

I love it!

But... if there is a 50mb text file it will download an render it 🙈 ? Maybe some small sanity check would make sense here... Only download if < 1 mb or so?

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Jul 21, 2017

Maybe some small sanity check would make sense here... Only download if < 1 mb or so?

How do I know? Pare the download button? 🙈

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Jul 21, 2017

How do I know? Pare the download button? 🙈

Ah - there is an hidden input field with the value.

@MorrisJobke
Render markdown files directly in public share
bd52e37 
renders markdown files for single share pages directly inline
and uses a readable styling

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the markdown-public-share-preview branch from 6664ee0 to bd52e37 Compare July 21, 2017 07:13
@MorrisJobke
Copy link
Member Author

MorrisJobke commented Jul 21, 2017

But... if there is a 50mb text file it will download an render it 🙈 ? Maybe some small sanity check would make sense here... Only download if < 1 mb or so?

Limited to 512 kB now. 😉

rullzer
rullzer approved these changes Jul 21, 2017
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MorrisJobke MorrisJobke merged commit 1b66b8a into master Jul 21, 2017
@MorrisJobke MorrisJobke deleted the markdown-public-share-preview branch July 21, 2017 14:13
@MorrisJobke MorrisJobke mentioned this pull request Jul 21, 2017
Merged
@jancborchardt
Copy link
Member

jancborchardt commented Jul 26, 2017 •
edited
Loading

Awesome, this looks so cool and makes it awesome to share simple notes! :)

(Btw on your Simplenote link, the rendering doesn't seem to work … also FYI, Simplenote server is not open source, until recently I thought that. ;)

@jancborchardt jancborchardt mentioned this pull request Jul 26, 2017
Merged
@MorrisJobke MorrisJobke mentioned this pull request May 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to review enhancement

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @rullzer @jancborchardt @LukasReschke