FilePickerBuilder: Allow to add custom buttons and use shipped picker#896
Merged
FilePickerBuilder: Allow to add custom buttons and use shipped picker#896
Conversation
Also fix linting issues Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…e global one Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
AndyScherzinger
approved these changes
Aug 15, 2023
Pytal
approved these changes
Aug 15, 2023
This was referenced Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file picker builder should support the custom buttons option. Also this changes the file picker builder to use the bundled file picker instead of the global one from the server.
(some linting fixes included (space to tab)).
Changes are kept simple so back porting to stable4 without being a breaking change should be simple.