Feature/boot swicth all#289
Merged
pszulczewski merged 3 commits intonetworktocode:developfrom Dec 22, 2023
juanjtomasg:feature/boot_swith_all
Merged
Feature/boot swicth all#289pszulczewski merged 3 commits intonetworktocode:developfrom juanjtomasg:feature/boot_swith_all
pszulczewski merged 3 commits intonetworktocode:developfrom
juanjtomasg:feature/boot_swith_all
Conversation
juanjtomasg
requested review from
jeffkala,
pke11y and
pszulczewski
as code owners
Contributor
|
Hi @jeffkala, @pszulczewski and @pke11y. Could you please review this PR? We believe it is interesting for the library. |
Contributor
|
@juanjtomasg thanks or the PR, I will review it and provide feedback. |
pszulczewski
added a commit
that referenced
this pull request
Jan 3, 2024
* Update for netmiko 4.x (#308) * Update kwargs in nxos_device.py to fix nautobot-nornir. * Pylint updates. * Update CI for pylint py version. * Fix exceptions * Fix NXOS timeout * Add refresh facts. * Remove save() from nxos install_os as it causes error. * Update pyntc/devices/aireos_device.py Post-review commit (lint) Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com> --------- Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com> * Feature/boot swicth all (#289) Extend cisco_ios boot option lookup. --------- Co-authored-by: tomasgaj <juan_jesus.tomas_garcia@roche.com> * Release 2.0.0 --------- Co-authored-by: Jeff Kala <48843785+jeffkala@users.noreply.github.com> Co-authored-by: juanjtomasg <66510649+juanjtomasg@users.noreply.github.com> Co-authored-by: tomasgaj <juan_jesus.tomas_garcia@roche.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C3650 devices do have a non matching syntax in current pyntc code.
C3650 #sh run | i boot system
boot system switch all flash:cat3k_caa-universalk9.SPA.03.07.01.E.152-3.E1.bin
The issue is that the current regex expression do not allow to have more than one string without spaces. Adding new regex expresion that allows to have the string "swicth all" within the boot system command.