Selection::resetOrder#54
Open
hranicka wants to merge 2 commits intonette:masterfrom
hranicka:feature/reset-order
Open
Selection::resetOrder#54hranicka wants to merge 2 commits intonette:masterfrom hranicka:feature/reset-order
hranicka wants to merge 2 commits intonette:masterfrom
hranicka:feature/reset-order
Conversation
Contributor
Author
There was a problem hiding this comment.
I've added also DESC keyword to previous test because without it result was the same as defined order in SQL fixture.
Contributor
|
I never had strong opinition, how many methods should be reflected in selection. |
src/Database/Table/Selection.php
Outdated
Contributor
There was a problem hiding this comment.
no need for call_user_func_, $this->sqlBuilder->setOrder([], []); is sufficient.
Contributor
Author
There was a problem hiding this comment.
Thanx. Why not call it directly if it has no magical arguments. Copy & Paste of ::order :(
Contributor
Author
|
@hrach It failing on PHP 5.3 - this version is no longer supported? |
Contributor
|
5.3 is failing, because it doesn't support the [] array syntax |
Contributor
Author
|
@redwormik Thx, I'm stupid or blind. |
dg
force-pushed
the
master
branch
4 times, most recently
from
0fc7ac2 to
7194522
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
6c43c50 to
6690dde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases it would be nice to have an option reset current order on the query.
I see that corresponding method ::setOrder is present in SqlBuilder since v2.3 but it's not used in Selection.
So I've added option for
ORDER BYclause reset.What do you think about that?