Skip to content

fix: plugin transform issues #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twlite merged 2 commits into from
Jun 22, 2025
Merged

fix: plugin transform issues #267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4df796d
fix: plugin transform
twlite Jun 22, 2025
3df19d5
fix: plugin transform errors
twlite Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/commandkit/src/plugins/plugin-runtime/CompilerPluginRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
isCompilerPlugin,
} from '..';
import { AsyncLocalStorage } from 'node:async_hooks';
import { Logger } from '../../logger/Logger';

/**
* Interface representing a template entry in the plugin runtime.
Expand Down Expand Up @@ -91,7 +92,7 @@ export class CompilerPluginRuntime {
}

/**
* Unregisters a template handler for a given name.
* Unregister a template handler for a given name.
* This method must be called inside the deactivate() method of a plugin.
* @param name - The name of the template to unregister.
*/
Expand Down Expand Up @@ -153,6 +154,13 @@ export class CompilerPluginRuntime {
): Promise<{ code: string; map: string | null }> {
let map: string | null = null;
for (const plugin of this.plugins) {
if (!plugin?.transform || typeof plugin?.transform !== 'function') {
Logger.warn(
`Plugin ${plugin?.name ?? '<unknown>'} is invalid or does not have a transform method or the method is not a function`,
);
continue;
}

try {
const res: MaybeFalsey<TransformedResult> = await plugin.transform?.({
code,
Expand Down