Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 98.65% 98.65%
=======================================
Files 140 140
Lines 2076 2083 +7
Branches 633 633
=======================================
+ Hits 2048 2055 +7
Misses 27 27
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } else { | ||
| if (wrapperChildren.length) { | ||
| newChildren.push(wrapper); | ||
| wrapper.bindChildren(wrapperChildren); |
There was a problem hiding this comment.
@jsamr I've checked the usage of nodeIndex, and it seems like the only thing that could break because of that is removing top and bottom margins in <li> components, but I tested it and it seems like it's working fine
|
@jsamr By the way: |
There was a problem hiding this comment.
Thanks for spotting the bug
Ideally we would keep track of the parent key to avoid an ancestry traversal on each node, and just use it as a prefix.
Will still allow the fix, but there may be performance issues for very large trees. Would be awesome to follow up
Closes #28