Merged
Conversation
Rather than storing a *LuaState inside the Lua struct, this changes Lua to be an opaque type that directly represents the memory passed to a Lua struct. Internally, this makes a few things slightly less readable. @ptrCast(lua) and @as(*LuaState, @ptrCast(lua)) are required when passing data to the c functions. But externally, this makes more sense. The value returned from Lua.init() is always a pointer now, and represents the Lua state itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than storing a
*LuaStateinside theLuastruct, this changesLuato be an opaque type that directly represents the Clua_State.Internally, this makes a few things slightly less readable.
@ptrCast(lua)and@as(*LuaState, @ptrCast(lua))are required when passing data to the c functions.But externally, I think this makes more sense. The value returned from
Lua.init()is always a pointer now, and is a direct pointer to the Lua state.Overall this change is really subjective. There isn't a strong reason to go one way or the other, but I do think I slightly prefer using an
opaque. It feels more "correct" to represent the opaque internal Lua state as a Zigopaquewith associated methods.