Added comptime convenience functions#55
Merged
natecraddock merged 11 commits intonatecraddock:mainfrom Feb 7, 2024
Merged
Conversation
natecraddock
requested changes
Jan 31, 2024
Owner
natecraddock
left a comment
natecraddock
left a comment
There was a problem hiding this comment.
I did a very high-level review. I still need to look at things more closely.
I see a few stray comments around still. Should these be removed? Or is there some more missing functionality?
Owner
|
I added a commit recently that should make this easier to implement: a213c57 Now you can just use pushFunction everywhere instead of switching on the language to see if it is luau. |
natecraddock
requested changes
Feb 7, 2024
Owner
natecraddock
left a comment
natecraddock
left a comment
There was a problem hiding this comment.
Overall looks good now. There are still many sections of commented code throughout the lib.zig and tests that should either be uncommented or removed
natecraddock
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently using my old implementations. I'm gonna make a few more improvements still