Add support for tagged userdata and userdata destructors#45
Merged
natecraddock merged 2 commits intonatecraddock:mainfrom Jan 12, 2024
Merged
Add support for tagged userdata and userdata destructors#45natecraddock merged 2 commits intonatecraddock:mainfrom
natecraddock merged 2 commits intonatecraddock:mainfrom
Conversation
Contributor
Author
|
This patch is also ready for review @natecraddock. Couple of notes:
The functionality added by userdatadtor is IMO required functionality in the Luau version, as Luau doesn't support the usual Lua __gc metatable function. |
Contributor
Author
|
I'll rebase since the other change went in |
Luau doesn't support the usual metatable __gc method, instead userdatadtors should be used. There's more information available about these differences here: luau-lang/luau#251 (comment)
natecraddock
requested changes
Jan 12, 2024
Owner
natecraddock
left a comment
There was a problem hiding this comment.
Thanks again for contributing! Just a couple of style things I pointed out
natecraddock
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Luau doesn't support the usual metatable __gc method, instead userdatadtors should be used. There's more information available about these differences here:
luau-lang/luau#251 (comment)
Pushing patch for FYI and review. This is probably the last of my pending Ziglua changes that I think make the Luau support reasonably complete to be used in let's say a game engine.