fix: Transition from ArrayList to ArrayListUnmanaged#174
Merged
robbielyman merged 2 commits intomainfrom Aug 17, 2025
Merged
Conversation
This fix anticipates upcoming changes in Zig 0.15 which will make `ArrayList` a synonym for `ArrayListUnmanaged` while still maintaining compatibility (for now) with Zig 0.14
This fix changes `define.zig` to follow emerging style preference in the Zig community for unmanaged data structures. In this particular case, this comes with O(n) memory savings, where n is the number of type definitions written, since the size of `String` goes from 4 * usize to 3.
Collaborator
Author
|
i think fetching might be broken on Windows nightly? not clear what is up. I'll go ahead and merge this and rerun CI in a couple days to see if the recent changes on Zig master have resolved the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix anticipates upcoming changes in Zig 0.15 which will make
ArrayLista synonym forArrayListUnmanagedwhile still maintaining compatibility (for now) with Zig 0.14