Merged
Conversation
robbielyman
force-pushed
the
push-otvqzvtzzqum
branch
from
c01a0f3 to
994d49e
Compare
Collaborator
Author
|
(the CI failures on nightly for windows appear unrelated and touch on stuff that is actively being worked on in Zig master) |
These functions rely (lightly) on Zig's comptime to minimize some of the annoying overhead of writing `@intCast` and `@floatCast` all the time by making those builtins part of the function definition. However, since those builtins assert in builds with runtime safety enabled, these functions will crash the program if called with bad Lua input. More discussion is warranted about the tradeoffs of going this route before merging. Resolves #172.
robbielyman
force-pushed
the
push-otvqzvtzzqum
branch
from
994d49e to
74e7cf7
Compare
Collaborator
Author
|
@nurpax I'd appreciate your eyes :) |
nurpax
reviewed
Aug 19, 2025
Contributor
nurpax
left a comment
nurpax
left a comment
There was a problem hiding this comment.
The semantics for the change are exactly as discussed. I did add some code comments though, since you asked. :) Nothing serious though.
robbielyman
force-pushed
the
push-otvqzvtzzqum
branch
from
1fc7ff6 to
1ace820
Compare
robbielyman
force-pushed
the
push-otvqzvtzzqum
branch
from
1ace820 to
e5d99be
Compare
robbielyman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions rely (lightly) on Zig's comptime to minimize some of the annoying overhead of writing
@intCastand@floatCastall the time by making those builtins part of the function definition. However, since those builtins assert in builds with runtime safety enabled, these functions will crash the program if called with bad Lua input. More discussion is warranted about the tradeoffs of going this route before merging.Resolves #172.