Fix breaking change for signature of alignedAlloc#148
Closed
e0328eric wants to merge 0 commit intonatecraddock:mainfrom
e0328eric:main
Closed
Fix breaking change for signature of alignedAlloc#148e0328eric wants to merge 0 commit intonatecraddock:mainfrom e0328eric:main
alignedAlloc#148e0328eric wants to merge 0 commit intonatecraddock:mainfrom
e0328eric:main
Conversation
Collaborator
|
ack, sorry, i'm very confused... |
Collaborator
|
oh i see, i'm sorry, i closed your pull request by accidentally pushing bad local state to your branch. i'll reopen from this repo with your commit... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of ziglang/zig#23548, some functions (eg. readFileAllocOptions, alignedAlloc) use std.mem.Alignment instead of raw u29.
In the current source code and the compiler version 0.15.0-dev.375+8f8f37fb0, there is only one place to fix it.