readme: change dependency name from ziglua to lua_wrapper#140
Merged
robbielyman merged 3 commits intomainfrom Mar 6, 2025
Merged
readme: change dependency name from ziglua to lua_wrapper#140robbielyman merged 3 commits intomainfrom
robbielyman merged 3 commits intomainfrom
Conversation
BREAKING: build.zig code in depending projects that calls
`ziglua.module("ziglua")` will need to be changed to call
`ziglua.module("lua_wrapper")`. probably it would be good for
depending build.zig code to also update the name of their dependency,
but that is not forced by this change.
nurpax
reviewed
Mar 6, 2025
Contributor
nurpax
left a comment
nurpax
left a comment
There was a problem hiding this comment.
Re your question in the PR overview: IMO all mentions of ziglua should be changed to lua_wrapper.
But shortening to lua_dep like you did here looks and reads well, so I like that over writing it out lua_wrapper_dep.
Collaborator
Author
|
since merging this would force all users of |
Collaborator
Author
|
i'm happy to merge as-is! any strong feelings about exporting a "ziglua" module for the time being? |
Contributor
|
I think it's better to go for full churn now this once. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the purpose of this PR is to close #139.
still left to consider:
build.zigis currently "ziglua", and the README adopts this module name in the examples. do we want to change it, or leave it as-is?