fix: remove Lua.equal with compile error for lua 5.2, 5.3, 5.4#118
Merged
robbielyman merged 2 commits intonatecraddock:mainfrom Nov 9, 2024
Merged
fix: remove Lua.equal with compile error for lua 5.2, 5.3, 5.4#118robbielyman merged 2 commits intonatecraddock:mainfrom
Lua.equal with compile error for lua 5.2, 5.3, 5.4#118robbielyman merged 2 commits intonatecraddock:mainfrom
Conversation
`lua_equal` is deprecated in Lua versions 5.2 and later; the same behavior can be achieved with `lua_compare` with the equality flag. this commit makes using `lua_equal` a compile error when `lang` is 5.2, 5.3 or 5.4. in fact, it is already a compile error (since the C header does not expose the function), but making it fail faster with a helpful replacement suggestion seems useful.
Open
natecraddock
reviewed
Nov 9, 2024
Owner
|
Thanks! Just noticed a tiny duplication in the comments. Sorry for the delay |
robbielyman
added a commit
to robbielyman/ziglua
that referenced
this pull request
Nov 29, 2024
…ecraddock#118) * fix: remove `Lua.equal` with compile error for lua 5.2, 5.3, 5.4 `lua_equal` is deprecated in Lua versions 5.2 and later; the same behavior can be achieved with `lua_compare` with the equality flag. this commit makes using `lua_equal` a compile error when `lang` is 5.2, 5.3 or 5.4. in fact, it is already a compile error (since the C header does not expose the function), but making it fail faster with a helpful replacement suggestion seems useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lua_equalis deprecated in Lua versions 5.2 and later; the same behavior can be achieved withlua_comparewith the equality flag. this commit makes usinglua_equala compile error whenlangis 5.2, 5.3 or 5.4. in fact, it is already a compile error (since the C header does not expose the function), but making it fail faster with a helpful replacement suggestion seems useful.I chose to leave the declaration of
equaluntouched: I think this is helpful for ZLS, which I find has a tough time resolvingswitch (lang)in my seamstress project, but I'm happy to take a different route too.