Target does not work for individual package

[mauritsvanrees]

See plone/documentation#1936 (comment)

In the coredev buildout the clone of the documentation does not end up in the place where it should be. Maybe install-mode = skip influences this.

In plone/buildout.coredev#1021 I am removing the clone for a different reason, so that fixes it for this case. But it would be good if someone can check why this does not work as expected.

[jensens]

Root Cause Analysis

Location: src/mxdev/config.py lines 79-103

The Bug:

At line 103, the code constructs the checkout path using the wrong variable:

# Line 79: Get the default-target from settings
target = settings.get("default-target", "sources")

for name in data.sections():
    ...
    # Line 86: Read package config - may contain custom "target" setting
    package = self._read_section(data, name)
    ...
    # Line 99: Set default target only if package doesn't specify one
    package.setdefault("target", target)
    ...
    # Line 103: BUG - uses 'target' variable instead of package["target"]
    package.setdefault("path", os.path.join(target, name))

Why it fails:

• Line 103 uses the target variable, which always equals default-target from line 79
• It should use package["target"], which may be a custom value from the package config
• Even if a package specifies target = custom-dir, it gets ignored
• The checkout path is always constructed as {default-target}/{packagename} instead of {package-target}/{packagename}

Example:

[settings]
default-target = sources
docs-directory = documentation

[mypackage]
url = https://github.com/example/mypackage.git
target = ${settings:docs-directory}

Current behavior: Checks out to sources/mypackage ❌
Expected behavior: Checks out to documentation/mypackage ✅

The Fix:

Change line 103 from:

package.setdefault("path", os.path.join(target, name))

To:

package.setdefault("path", os.path.join(package["target"], name))