Fix test and add TestImmutableValue #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tsuyoshi Ozawa <[email protected]>
Member
There was a problem hiding this comment.
Java guarantees that you can't override Enum#equals. You don't have to check whether expected is the only value in the valueTypes. Assertion can be assertTrue(ValueType.NIL == v.getType()).
Member
There was a problem hiding this comment.
Instead, you need to verify ValueType.isXxxType methods?
Signed-off-by: Tsuyoshi Ozawa <[email protected]>
Signed-off-by: Tsuyoshi Ozawa <[email protected]>
Signed-off-by: Tsuyoshi Ozawa <[email protected]>
frsyuki
added a commit
that referenced
this pull request
May 4, 2014
Fix test and add TestImmutableValue
Member
|
Looks good first implementation 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 fixes:
mvn test. org.msgpack.core.Person has Message annotation, but v07 has not had the annotation. This causes compile error when we executemvn test.