fix: screenshots not supporting css @layers (@miodec) #7450
+165
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miodec
changed the title
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes screenshot generation issues with CSS @layers by implementing font embedding with data URLs, allowing fonts and FontAwesome to be properly placed within CSS layers.
Changes:
- Added font embedding utilities that extract @font-face rules from layers, convert font URLs to data URLs, and inject them into screenshots
- Moved FontAwesome import back into @layer vendor (previously outside layers)
- Moved fonts import back into @layer custom-styles (previously outside layers)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| frontend/src/ts/test/test-screenshot.ts | Added font embedding logic to extract and embed font files as data URLs for screenshot generation, replacing the previous workaround of keeping fonts outside CSS layers |
| frontend/src/styles/vendor.scss | Moved FontAwesome import into @layer vendor and removed explicit hidden/invisible overrides (now handled by the hidden layer) |
| frontend/src/styles/index.scss | Moved fonts import into @layer custom-styles |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fehmer
added a commit
that referenced
this pull request
Jan 26, 2026
fehmer
added a commit
that referenced
this pull request
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI goes BRRRRRR
this moves fonts and fontawesome back to layers where they belong.
Thirds time the charm.