refactor: remove jq from sorted table (@miodec) #7406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the SortedTable class to remove jQuery dependency by replacing it with custom DOM utility wrappers (ElementWithUtils and ElementsWithUtils). The refactoring maintains the same functionality while using a more modern, type-safe approach.
Changes:
- Replaced jQuery methods with custom DOM utilities in
sorted-table.ts - Extended
ElementWithUtils.append()to support arrays andElementsWithUtils - Added
getChildren()methods to bothElementWithUtilsandElementsWithUtils - Added
appendHtml()method toElementsWithUtils
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/ts/utils/sorted-table.ts | Refactored to use ElementWithUtils instead of jQuery, replacing jQuery methods with custom DOM utility equivalents |
| frontend/src/ts/utils/dom.ts | Extended append() method to handle arrays, added getChildren() and appendHtml() methods to support the refactoring |
| frontend/src/ts/pages/friends.ts | Updated SortedTable instantiation to pass ElementWithUtils via qsr() instead of string selector |
| frontend/src/ts/pages/account.ts | Updated SortedTableWithLimit instantiation to pass ElementWithUtils via qsr() instead of string selector |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fehmer
approved these changes
Jan 21, 2026
github-actions
bot
removed
the
waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates and adds some dom utils