-
-
Notifications
You must be signed in to change notification settings - Fork 3k
feat: add Kinyarwanda language (@cedrick13bienvenue) #7400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add Kinyarwanda language (@cedrick13bienvenue) #7400
Conversation
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
| @@ -0,0 +1,280 @@ | |||
| { | |||
| "name": "kinyarwanda", | |||
| "noLazyMode": true, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the bcp47 property. should be "rw-RW" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
thanks for heads-up!
Description
This PR adds support for the Kinyarwanda language.
kinyarwanda.jsonwith a word list of 200+ unique, lowercase words."kinyarwanda"in the sharedLanguageSchemawithinpackages/schemasto ensure type safety across the monorepo."kinyarwanda"to theLanguageGroupsin the frontend constants so it appears correctly in the user settings menu under the appropriate category.Checks
Adding/modifying Typescript code?
I have used
qs,qsaorqsrinstead of JQuery selectors.Adding quotes?
Adding a language?
Make sure to follow the [languages documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LANGUAGES.md)
Add language to
packages/schemas/src/languages.tsAdd language to exactly one group in
frontend/src/ts/constants/languages.tsAdd language json file to
frontend/static/languagesAdding a theme?
Adding a layout?
Adding a font?
Check if any open issues are related to this PR; if so, be sure to tag them below.
Make sure the PR title follows the Conventional Commits standard.
Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.