Introduce Netty benchmark suite.#1647
Merged
vbabanin merged 15 commits intomongodb:mainfrom Apr 2, 2025
Merged
Conversation
JAVA-5813
JAVA-5813
JAVA-5813
# Conflicts: # driver-benchmarks/build.gradle
JAVA-5813
rozza
requested changes
Mar 31, 2025
Member
rozza
left a comment
rozza
left a comment
There was a problem hiding this comment.
Looks good to me. Just some merge conflicts to fix.
# Conflicts: # driver-benchmarks/src/main/com/mongodb/benchmark/benchmarks/AbstractMongoBenchmark.java # driver-benchmarks/src/main/com/mongodb/benchmark/benchmarks/AbstractWriteBenchmark.java
JAVA-5813
rozza
reviewed
Apr 1, 2025
| throws Exception { | ||
| runBenchmark(new RunCommandBenchmark<>(DOCUMENT_CODEC) | ||
| .applyMongoClientSettings(MONGO_CLIENT_SETTINGS)); | ||
| runBenchmark(new FindOneBenchmark<Document>("single_and_multi_document/tweet.json", |
Member
There was a problem hiding this comment.
Only observation is that many other file paths are prefixed with "./"
Member
Author
There was a problem hiding this comment.
Changed to ""./" for consistency. Thanks!
rozza
reviewed
Apr 1, 2025
Member
rozza
left a comment
rozza
left a comment
There was a problem hiding this comment.
Code looks good - do you have a link to and example of it running on evergreen?
Member
Author
JAVA-5813
rozza
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1646 [Merged]
JAVA-5813