This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Default bind mounts to rshared not rprivate if not specified#210
Merged
justincormack merged 1 commit intomoby:masterfrom Apr 4, 2018
Merged
Default bind mounts to rshared not rprivate if not specified#210justincormack merged 1 commit intomoby:masterfrom
justincormack merged 1 commit intomoby:masterfrom
Conversation
It is quite confusing that from the host or another container that binds `/containers` you cannot see the bind mounts, you have to enter the container namespace. I think `rshared` is a better default. You can always be explicit and add `private` if you want a private bind mount. Signed-off-by: Justin Cormack <justin.cormack@docker.com>
justincormack
added a commit
to justincormack/linuxkit
that referenced
this pull request
Apr 4, 2018
This only includes moby/tool#210 which makes bind mounts into containers rshared not rprivate by default, which makes debug easier as you can see them from the host. Signed-off-by: Justin Cormack <justin@specialbusservice.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is quite confusing that from the host or another container that
binds
/containersyou cannot see the bind mounts, you have to enterthe container namespace. I think
rsharedis a better default. Youcan always be explicit and add
privateif you want a private bind mount.Signed-off-by: Justin Cormack justin.cormack@docker.com