Merged
Conversation
bladyjoker
approved these changes
Feb 8, 2023
Contributor
bladyjoker
left a comment
bladyjoker
left a comment
There was a problem hiding this comment.
Generally, I'm ok with merging this. Please collect all the TODOs in an issue or PR.
I'm not happy with Pat, and not because it's incorrect, it's just ad-hoc in a sense that it introduces some obscurity in the underlying intention and definitely introduces more code then necessary.
I'll write up an issue about this.
Contributor
|
@gnumonik , please merge with latest main as Vlad committed some changes today. |
This was referenced Feb 8, 2023
Co-authored-by: Dražen Popović <bladyjoker@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is everything that doesn't depend on
Solve. As per your instructions @bladyjoker I will open another PR with the rest of the TypeClass stuff once you give the OK.(I'm not sure if you want just
Solveor everything else in the next PR, please let me know)