Closed
Conversation
pqoqubbw
approved these changes
Mar 10, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| children?: ReactNode; | ||
| copyButtonProps?: CopyToClipboardButtonProps; | ||
| isParentCodeGroup?: boolean; | ||
| shouldHighlight?: boolean; |
There was a problem hiding this comment.
Redundant prop declarations in extending interface
Low Severity
Adding isParentCodeGroup and shouldHighlight to CodeBlockProps creates redundancy with BaseCodeBlockProps, which extends CodeBlockProps and re-declares the exact same two properties. Only forceExtract is actually unique to BaseCodeBlockProps. If the types diverge in the future (e.g., one becomes required), the override in BaseCodeBlockProps could silently mask the change.
Contributor
Author
|
closing to take another approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
parent CodeBlock that is exported was missing a few props (isParentCodeGroup and shouldHighlight) - it should pass all of its props to the Base Code Block component. slightly refactors the props destructuring
Test Plan
Note
Low Risk
Small wrapper-component fix that mainly affects prop forwarding and conditional rendering, with limited blast radius to code-block UI behavior.
Overview
Fixes the exported
CodeBlockwrapper to expose and forward additional props (isParentCodeGroup,shouldHighlight) by passing the fullparamsthrough toBaseCodeBlockinstead of selectively overriding props.Also updates
askAiButtonrendering to consistently respecthideAskAiButtonin both header and floating-button layouts, and slightly refactors prop destructuring to avoid dropping/duplicating values.Written by Cursor Bugbot for commit d7e94af. This will update automatically on new commits. Configure here.