Match querystring for multiple responses in httpretty plugin#295
Merged
mindflayer merged 1 commit intomindflayer:mainfrom Jun 10, 2025
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 22 22
Lines 1010 1010
=======================================
Hits 997 997
Misses 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@wilhelmklopp here you have a new release with your change: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



I'm migrating a large codebase with lots of http mocking from httpretty to python-mocket and making heavy use of your httpretty plugin – many thanks for making this and for actively maintaining python-mocket! ❤️ It is much appreciated!
This PR makes sure match_querystring is passed along properly to ~Entry
when multiple responses are registered using the httpretty plugin.match_querystring` is already passed along as expected when a single response is registered, but not currently when multiple responses are registered.This change makes a bunch of my tests pass, that otherwise would not