Add type hints to mocket.plugins.httpretty

[JPDSousa]

See #203

While the type hints introduced are not that extensive, they do pass some basic mypy rules (e.g., disallow_untyped_decorators).

I used tests.test_httpretty to test the type hints introduced. Again, while it's not an exhaustive approach, it provides some sanity check that types work as expected.

[JPDSousa]

Quality Gate failed

Failed conditions E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Remove this unexpected named argument 'kwsyntax'.

@mindflayer is this because I removed unused-ignore?

[mindflayer]

is this because I removed unused-ignore?

I think those are two different things:

• unused-ignore is there because we want to keep the retro-compatibility with older versions of decorator (see https://github.com/mindflayer/python-mocket/actions/runs/14855561175/job/41715155466?pr=290);
• SonarCloud is saying that keyword does not exist (which is true for the version that is used for testing) (I've just flagged the issue as "won't fix" on SonarCloud side).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (2ad3bec) to head (8b2eeda).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   98.59%   98.70%   +0.11%     
==========================================
  Files          22       22              
  Lines         994     1004      +10     
==========================================
+ Hits          980      991      +11     
+ Misses         14       13       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[JPDSousa]

@mindflayer here's the status of both failing checks:

1. codecov is failing due to the added type ignore in get_mocketize
2. Mocket's CI fails because httpbin.org is really unavailable.

What do you suggest?

[mindflayer]

Mocket's CI fails because httpbin.org is really unavailable.

For when this happens, the only possible solution is waiting and retry, which is what I've just done (it's now flagged as succeeded).

I tried a bunch of similar services, and of course they do not work 100% of the times (which is the actual reason for Mocket to exist in the first place: to make CIs great again :) ).

[JPDSousa]

Added unit tests to get mocketize to make the coverage happy

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[JPDSousa]

@mindflayer This should be ready to review. The CI is failing again due to httpbin

[mindflayer]

I noticed that, which was the reason why I couldn't finish. I'm putting my little daughter to bed and will try again soon.

…

On Tue, 6 May 2025, 20:02 João Sousa, ***@***.***> wrote: *JPDSousa* left a comment (mindflayer/python-mocket#290) <#290 (comment)> @mindflayer <https://github.com/mindflayer> This should be ready to review. The CI is failing again due to httpbin — Reply to this email directly, view it on GitHub <#290 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEAXXO5OO66ECL25OAC7OL25D2LDAVCNFSM6AAAAAB4QSXVD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNJVGQ3DSOBUGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>