Recording: support removing headers from recorded data#271
Closed
wojciak wants to merge 5 commits intomindflayer:mainfrom
e-z-health:feature/recording-ignored-headers
Closed
Recording: support removing headers from recorded data#271wojciak wants to merge 5 commits intomindflayer:mainfrom e-z-health:feature/recording-ignored-headers
wojciak wants to merge 5 commits intomindflayer:mainfrom
e-z-health:feature/recording-ignored-headers
Conversation
wojciak
commented
Nov 25, 2024
- This PR adds the ability to provide a response header filter when recording a mocketized request.
- The reasoning for this feature is to allow implementers to specify non-safe headers (like authorization tokens etc) and to be able to safely commit the recordings into their projects.
Co-authored-by: Clemens Wolff <clemens@justamouse.com>
|
Owner
|
Same problem here, you are adding code that deals with the HTTP protocol in Mocket core. |
Author
|
@mindflayer Got it, the question is then: is there any plan to realise items like this as plugins / specific injectors in the future? Unfortunately the recording feature is vowed into the core directly, so this is the best approach I've came up with. |
Owner
This is about to change: see #274 We will offer a way to simply specify a |
Author
|
@mindflayer awesome, closing this PR then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

