Invoke-GraphRequest cmdlet to allow direct requests using underlying HttpClient#245
Merged
Invoke-GraphRequest cmdlet to allow direct requests using underlying HttpClient#245
Conversation
added 2 commits
May 20, 2020 00:56
Use Http enum for validation.
ddyett
reviewed
Jun 2, 2020
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
ddyett
reviewed
Jun 2, 2020
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
peombwa
reviewed
Jun 10, 2020
- Enable users to download files to current directory either with custom name or inferred name. - Enable users to pass their own headers. - When Errors happen, print out the whole HttpResponse including headers. - Enable -PassThru, -Verbose (with useful messages)
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
peombwa
requested changes
Jun 26, 2020
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
zengin
reviewed
Jun 29, 2020
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
zengin
reviewed
Jun 29, 2020
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
zengin
reviewed
Jun 29, 2020
zengin
reviewed
Jun 29, 2020
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
zengin
reviewed
Jun 29, 2020
src/Authentication/Authentication/Cmdlets/InvokeGraphRequest.cs
Outdated
Show resolved
Hide resolved
zengin
reviewed
Jun 29, 2020
zengin
reviewed
Jun 29, 2020
| { | ||
| GraphRequestSession.ContentHeaders.Add(entry.Key, entry.Value); | ||
| } | ||
| else |
zengin
reviewed
Jun 29, 2020
src/Authentication/Authentication/Helpers/HttpMessageFormatter.cs
Outdated
Show resolved
Hide resolved
zengin
reviewed
Jun 30, 2020
zengin
reviewed
Jun 30, 2020
zengin
reviewed
Jun 30, 2020
zengin
reviewed
Jun 30, 2020
zengin
suggested changes
Jun 30, 2020
Contributor
zengin
left a comment
zengin
left a comment
There was a problem hiding this comment.
Please consider using functionality from standard library whenever possible.
added 12 commits
July 8, 2020 02:07
Move strings to resource file.
Perf improvement, check for token length first.
Extra validation.
zengin
reviewed
Jul 13, 2020
zengin
approved these changes
Jul 13, 2020
Contributor
zengin
left a comment
zengin
left a comment
There was a problem hiding this comment.
looks good to me for local changes, please wait for approval from someone who knows the high level functionality better.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an Invoke-GraphRequest cmdlet that enables users to make requests using the underlying authenticated HttpClient.
Example
Invoke-GraphRequest -Method GET -Uri https://graph.microsoft.com/beta/meInvoke-GraphRequest -Method GET -Uri /beta/meTo support non-json responses requires a change in msgraph-sdk-dotnet-core whose compression handler currently doesn't pass along Http Content headers to the next middleware in the pipeline
Address AB#4897