Fix default upload size (5 instead of 4)#73
Closed
marcoscheel wants to merge 1 commit intomicrosoftgraph:devfrom
Closed
Fix default upload size (5 instead of 4)#73marcoscheel wants to merge 1 commit intomicrosoftgraph:devfrom
marcoscheel wants to merge 1 commit intomicrosoftgraph:devfrom
Conversation
If LargeFileUploadTask is called without the maxSliceSize parameter the default will be picked. But the default was 4*1024*1024 and that is not a multiplier of 320! So a caller must specify the size, even if they want to stick to the defaults (that may be changed in the future).
Contributor
|
@marcoscheel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If LargeFileUploadTask is called without the maxSliceSize parameter the default will be picked. But the default was 410241024 and that is not a multiplier of 320! So a caller must specify the size, even if they want to stick to the defaults (that may be changed in the future).
Fixes #
Changes proposed in this pull request
Other links