Skip to content

Use common serializer in Batch requests and responses#66

Merged
andrueastman merged 1 commit intodevfrom
andrueastman/fix-json-deserilizer
Dec 3, 2019
Merged

Use common serializer in Batch requests and responses#66
andrueastman merged 1 commit intodevfrom
andrueastman/fix-json-deserilizer

Conversation

@andrueastman
Copy link
Contributor

@andrueastman andrueastman commented Nov 28, 2019 •
edited
Loading

This PR fixes microsoftgraph/msgraph-sdk-dotnet#587 and fixes microsoftgraph/msgraph-sdk-dotnet#291

Changes proposed in this pull request

  • Updates method overload DeserializeObject<T>(Stream stream) in Serializer to use common serializer settings
  • Uses common serializer for intermediate de/serialization in BatchRequestContent and BatchResponseContent to fix inconsistent responses as seen in this issue
  • Adds tests to validate date values are consistent before/after serialization for BatchRequestContent and BatchResponseContent

@andrueastman andrueastman self-assigned this Nov 28, 2019
@andrueastman andrueastman merged commit 7bf1f20 into dev Dec 3, 2019
@andrueastman andrueastman deleted the andrueastman/fix-json-deserilizer branch December 3, 2019 05:43
@andrueastman andrueastman mentioned this pull request Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peombwa peombwa Awaiting requested review from peombwa

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

1 more reviewer

@darrelmiller darrelmiller darrelmiller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andrueastman andrueastman

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@andrueastman @darrelmiller