Improve ServiceException/Error class information#37
Merged
MIchaelMainer merged 5 commits intodevfrom Oct 1, 2019
Merged
Conversation
**modified: src/Microsoft.Graph.Core/Exceptions/Error.cs** Added Target, Details, and ClientRequestId properties and updated the ToString() method. **new file: src/Microsoft.Graph.Core/Exceptions/ErrorDetails.cs** Supports the Error.Details property per OData spec. **modified: src/Microsoft.Graph.Core/Exceptions/ServiceException.cs** Added support for adding the raw response body. **modified: src/Microsoft.Graph.Core/Requests/HttpProvider.cs** Added support for adding the raw response body and ClientRequestId for ServiceExceptions. modified: tests/Microsoft.Graph.DotnetCore.Core.Test/Exceptions/ErrorTests.cs modified: tests/Microsoft.Graph.DotnetCore.Core.Test/Requests/HttpProviderTests.cs **Addresses** * Fixes #23 * Fixes microsoftgraph/msgraph-sdk-dotnet#316
MIchaelMainer
requested review from
FiromsaA,
darrelmiller,
millicentachieng and
peombwa
MIchaelMainer
requested review from
andrueastman
and removed request for
FiromsaA
Contributor
andrueastman
left a comment
andrueastman
left a comment
There was a problem hiding this comment.
Save for the question on the additional constructor in the ServiceException class, this looks good to me really.
…eption cstor, fixed typo in change summary, added HttpContent.LoadIntoBufferAsync so we can read the stream twice, updated tests.
…oftgraph/msgraph-sdk-dotnet-core into mm/provideRawErrorDetails
darrelmiller
approved these changes
Oct 1, 2019
MIchaelMainer
added a commit
that referenced
this pull request
Oct 10, 2019
Merge pull request #44 from microsoftgraph/dev - Add SimpleHttpProvider for GraphClientFactory compatibility - Adds tests to validate similar behavior to HttpProvider - Add modified checks to not authenticate SimpleHttprovider when authprovider is presents - Bumps up version number. - Improve ServiceException/Error class information (#37) - Updates release notes - Added Target, Details, and ClientRequestId properties and updated the ToString() method. - Added support for adding the raw response body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modified: src/Microsoft.Graph.Core/Exceptions/Error.cs
Added Target, Details, and ClientRequestId properties and updated the
ToString() method.
new file: src/Microsoft.Graph.Core/Exceptions/ErrorDetails.cs
Supports the Error.Details property per OData spec, 9.4 Error Response Body details object.
http://docs.oasis-open.org/odata/odata/v4.01/csprd05/part1-protocol/odata-v4.01-csprd05-part1-protocol.html#_Toc14172757
modified: src/Microsoft.Graph.Core/Exceptions/ServiceException.cs
Added support for adding the raw response body.
modified: src/Microsoft.Graph.Core/Requests/HttpProvider.cs
Added support for adding the raw response body and ClientRequestId for
ServiceExceptions.
modified: tests/Microsoft.Graph.DotnetCore.Core.Test/Exceptions/ErrorTests.cs
modified: tests/Microsoft.Graph.DotnetCore.Core.Test/Requests/HttpProviderTests.cs
Addresses