Skip to content

Submitting sqlcmd version 0.8.1#79565

Merged
1 commit merged intomicrosoft:masterfrom
stuartpa:sqlcmd-0.8.1
Sep 19, 2022
Merged

Submitting sqlcmd version 0.8.1#79565
1 commit merged intomicrosoft:masterfrom
stuartpa:sqlcmd-0.8.1

Conversation

@stuartpa
Copy link
Contributor

@stuartpa stuartpa commented Sep 14, 2022 •
edited by ghost
Loading

  • [Y] Have you signed the Contributor License Agreement?
  • [Y] Have you checked that there aren't other open pull requests for the same manifest update/change?
  • [Y] Have you validated your manifest locally with winget validate --manifest <path>?
  • [Y] Have you tested your manifest locally with winget install --manifest <path>?
  • [Y] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

wingetbot commented Sep 14, 2022

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

wingetbot commented Sep 14, 2022

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 14, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@stuartpa stuartpa mentioned this pull request Sep 14, 2022
Closed
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 14, 2022
@ghost ghost assigned hackean-msft and JohnMcPMS Sep 14, 2022
ItzLevvie
ItzLevvie suggested changes Sep 14, 2022
View reviewed changes
manifests/m/Microsoft/Sqlcmd/0.8.1/Microsoft.Sqlcmd.locale.en-US.yaml
PublisherSupportUrl: https://github.com/microsoft/go-sqlcmd
# PrivacyUrl:
# Author:
PackageName: Sqlcmd
Copy link
Contributor

@ItzLevvie ItzLevvie Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PackageName: Sqlcmd
PackageName: Sqlcmd Tools

This must match Control Panel.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Sep 14, 2022
@ghost ghost assigned stuartpa Sep 14, 2022
@ghost
Copy link

ghost commented Sep 14, 2022

Hello @stuartpa,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@hackean-msft
Copy link
Contributor

hackean-msft commented Sep 15, 2022

@wingetbot waivers Add Validation-Executable-Error

@wingetbot
Copy link
Collaborator

wingetbot commented Sep 15, 2022

/AzurePipelines run

@ghost ghost removed Validation-Executable-Error Needs-Attention This work item needs to be reviewed by a member of the core team. Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. labels Sep 15, 2022
@azure-pipelines
Copy link

azure-pipelines bot commented Sep 15, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 15, 2022
@ghost
Copy link

ghost commented Sep 15, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Sep 15, 2022

stuartpa,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

ItzLevvie
ItzLevvie suggested changes Sep 18, 2022
View reviewed changes
Copy link
Contributor

@ItzLevvie ItzLevvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #79565 (review)

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Sep 18, 2022
@ghost ghost assigned stuartpa Sep 18, 2022
@ghost
Copy link

ghost commented Sep 18, 2022

Hello @stuartpa,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@ItzLevvie
Copy link
Contributor

ItzLevvie commented Sep 19, 2022

@wingetbot run

@wingetbot
Copy link
Collaborator

wingetbot commented Sep 19, 2022

/AzurePipelines run

@ghost ghost removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. labels Sep 19, 2022
@azure-pipelines
Copy link

azure-pipelines bot commented Sep 19, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 19, 2022
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 19, 2022
@ghost
Copy link

ghost commented Sep 19, 2022

Hello stuartpa,
Validation has completed.

Template: msftbot/validationCompleted

@ghost ghost merged commit 3b9de05 into microsoft:master Sep 19, 2022
@wingetbot
Copy link
Collaborator

wingetbot commented Sep 19, 2022

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@stuartpa stuartpa deleted the sqlcmd-0.8.1 branch September 20, 2022 15:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Executable-Error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stuartpa @wingetbot @hackean-msft @ItzLevvie @JohnMcPMS