-
Notifications
You must be signed in to change notification settings - Fork 36
Open
Labels
area-activationIssue related to activation. Root cause can be from interpreter selection or activation in terminalIssue related to activation. Root cause can be from interpreter selection or activation in terminalarea-terminalEnvironment extension specific terminal issues.Environment extension specific terminal issues.bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug
Milestone
Description
env extension api createTerminal api doesnt seem to wait enough for command activation, contributing to issues like: #640 (comment)
Code pointer:
vscode-python-environments/src/features/terminal/terminalActivationState.ts
Lines 256 to 260 in 98cc93a
| const promise = new Promise<void>((resolve) => { | |
| const timer = setTimeout(() => { | |
| traceError(`Shell execution timed out: ${command}`); | |
| resolve(); | |
| }, 2000); |
It seems like we race 2 second, but this is simply not enough since realistic executeCommand for activation command will be 4~
We should wait longer so when we use createTerminal api for both file execution, and Python code execution, we can provide activated terminal before running either of those scenario for command activation type of users.
Metadata
Metadata
Assignees
Labels
area-activationIssue related to activation. Root cause can be from interpreter selection or activation in terminalIssue related to activation. Root cause can be from interpreter selection or activation in terminalarea-terminalEnvironment extension specific terminal issues.Environment extension specific terminal issues.bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bug