Skip to content

Comments

bugfix: Data tree node not found#484

Merged
jdneo merged 1 commit intomasterfrom
cs/issue-478
Apr 23, 2021
Merged

bugfix: Data tree node not found#484
jdneo merged 1 commit intomasterfrom
cs/issue-478

Conversation

@jdneo
Copy link
Member

@jdneo jdneo commented Apr 22, 2021

fix #478

@jdneo jdneo added this to the 0.18.4 milestone Apr 22, 2021
@Eskibear
Copy link
Member

It looks you are using await-lock to replace previously self-implemented one. So what's the root cause? Is previous one not working?

@jdneo
Copy link
Member Author

jdneo commented Apr 22, 2021

await-lock is just to reuse the module that has the same functionality.

The root cause of this bug is that, before this PR, there are different factors causing the explorer to refresh:

  1. when reveal a node, it will trigger the explorer to getChildren() until the node is found
  2. When server mode changed, the explorer will be refreshed entirely

Then problem happens, because the refresh is not an atomic operation (multiple getChildren() being called from different levels), thus the multiple refresh operation will race with each other, and break the cache.

So in this PR, I add some condition check that prevent those redundant refresh requests being called during activation. Then during the activation, there will be only one reveal operation being called.

@jdneo jdneo merged commit 341ac5b into master Apr 23, 2021
@jdneo jdneo deleted the cs/issue-478 branch April 23, 2021 09:18
@CsCherrYY CsCherrYY added the bug Something isn't working label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Data tree node not found in console

3 participants