Add backward compatibility support for missing public constructors #9484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Regenerating SDKs from TypeSpec (previously from autorest) drops public constructors, breaking existing code. Example from Azure.Search.Documents:
Previous (autorest):
Current (TypeSpec without fix):
Changes
Core Implementation
Signature Matching
ConstructorSignatureComparercompares modifiers, parameter count, and parameter types/namesGenerated Code
Testing
BackCompat_MissingPublicParameterlessConstructortestBackCompat_MissingPublicConstructorWithParametertestOriginal prompt
This section details on the original issue you should resolve
<issue_title>[Bug]: Backward Compatibility not generating pre-existing public constructors</issue_title>
<issue_description>### Describe the bug
Pre-existing public constructors should not be missing from the generated code. This should be another Back Compat scenario. See Backward Compatibility Support for more details.
Generating Azure.Search.Documents have the issue where a public constructor is missing, for instance, this is what the previously generated code from autorest looks like:
and the new generated model looks like: