Fix ts-pre-modules to work with updated outFile buildinfo changes#71
Merged
jakebailey merged 1 commit intomainfrom Jun 4, 2024
Merged
Fix ts-pre-modules to work with updated outFile buildinfo changes#71jakebailey merged 1 commit intomainfrom
jakebailey merged 1 commit intomainfrom
Conversation
sheetalkamat
approved these changes
Jun 4, 2024
sheetalkamat
reviewed
Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
microsoft/TypeScript#58760 made outFile always emit buildinfo, which then caused this benchmark to start being "too fast" because it's actually incremental.
Testing incremental is a good idea in general, but this benchmark was not actually intended to test that, so disable composite mode and fix the flag (which should not have been outdir).