fix(fabric, lists): disable view flattening in VirtualizedList#2292
Merged
Saadnajmi merged 2 commits intomicrosoft:mainfrom Nov 28, 2024
Merged
fix(fabric, lists): disable view flattening in VirtualizedList#2292Saadnajmi merged 2 commits intomicrosoft:mainfrom
Saadnajmi merged 2 commits intomicrosoft:mainfrom
Conversation
Saadnajmi
force-pushed
the
fabric/flatlist
branch
3 times, most recently
from
0753449 to
f7a8d4a
Compare
added 2 commits
November 27, 2024 20:49
Summary:
Scroll views set up with an inverted vertical axis can't support view flattening due to the flattening not taking the axis inversion in consideration while repositioning the views.
This diff disables view flattening on the cells of the virtualized list so that the layout would be correct in inverted scroll views when using Fabric.
The change is not being applied to ScrollView directly because we can safely assume that vertical axis inversion will only be enabled on VirtualizedList/FlatList.
Test Plan:
Run Zeratul with Fabric and check that the vertical order of grouped bubble messages is correct.
| Before | After |
|--|
| {F1136386200} | {F1136386364} |
Reviewers: shawndempsey, #rn-desktop
Reviewed By: shawndempsey
Differential Revision: https://phabricator.intern.facebook.com/D50846483
Tasks: T167539420
…ents of VirtualizedList
Summary:
View flattening was already disabled in the cell renderer used by the Virtualized List in this diff D50846483
This diff disables view flattening in the header, footer, empty and spacer cells to fix the layout being broken because of the vertical axis flipping used by the reverse order virtualized list.
Test Plan:
Run Zeratul with Fabric enabled and scroll to the top of a message thread to show the participants summary header.
| Before | After |
|--|
| {F1145726580} | {F1145726618} |
Reviewers: shawndempsey, chpurrer, #rn-desktop
Reviewed By: chpurrer
Differential Revision: https://phabricator.intern.facebook.com/D51182545
Tasks: T167539420
Saadnajmi
force-pushed
the
fabric/flatlist
branch
from
f7a8d4a to
2649005
Compare
tido64
approved these changes
Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of a series of PRs where we are cherry-picking fixes from #2117 to update our Fabric implementation on macOS.
Summary:
Pick a few commits that disable view flattening in Flatlist / VirtualizedList
Test Plan:
CI should pass