Skip to content

Conversation

@SidneyCogdill
Copy link
Contributor

Closes #306.


BTW Is the write_basic_package_version_file in the root CMakeLists.txt necessary anymore?

@tian-lt tian-lt requested a review from Copilot June 6, 2025 03:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the package and namespace from "proxy4" to "msft_proxy4" to ensure consistency between package names and namespace identifiers. Key changes include renaming CMake targets and variables, updating documentation, and modifying test references to reflect the new naming convention.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

File Description
tests/cpp20_modules/CMakeLists.txt Updated target linking to use the new module alias (msft_proxy4::proxy_module).
tests/CMakeLists.txt Updated target linking to use the new interface alias (msft_proxy4::proxy).
docs/* Updated documentation to reference msft_proxy4 instead of proxy4.
cmake/* and CMakeLists.txt Renamed targets, include directories, and configuration files accordingly.
Comments suppressed due to low confidence (2)

tests/cpp20_modules/CMakeLists.txt:13

  • Confirm that the use of msft_proxy4::proxy_module for C++ module tests is intentional and distinct from the interface target (msft_proxy4::proxy) used elsewhere. Consider adding a brief note in the documentation to clarify the differences between these targets.
target_link_libraries(msft_proxy_tests PRIVATE msft_proxy4::proxy_module)

tests/CMakeLists.txt:42

  • Ensure the distinction between msft_proxy4::proxy and msft_proxy4::proxy_module is clear and intentional, as they are used in different contexts within the tests. It could be helpful to document this distinction to prevent future confusion.
target_link_libraries(msft_proxy_tests PRIVATE msft_proxy4::proxy)

@tian-lt
Copy link
Collaborator

tian-lt commented Jun 6, 2025

BTW Is the write_basic_package_version_file in the root CMakeLists.txt necessary anymore?

I'd suggest keeping the ConfigVersion with SameMajorVersion because we want proxy to be compatible to those versions that have the same major version.

@mingxwa mingxwa merged commit cf6c633 into microsoft:main Jun 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake package name and target namespace mismatch

3 participants