Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
proxy_invoke, pass the reference ofproxyinstead of the reference ofproxy::ptr_to the indirect function pointer. With this change, the assembly generated from caller side could be further optimized.For example, for the code presented in section 5.1.3, P3086R3:
Here is a comparison table of the generated assembly before and after this change:
add rdi, 8
jmp qword ptr [rax + 16]
jmp qword ptr [rax + 16]
ldr x1, [x8, #16]
br x1
ldr x1, [x8, #16]
br x1
ld a5, 16(a1)
addi a0, a0, 8
jr a5
ld a5, 16(a1)
jr a5
nullptr, butproxyorproxy_indirect_accessor. This allows invoking otherproxyfunctions from within a dispatch, similar to adefaultmethod in C# or Java.PRO_DEF_WEAK_DISPATCH(deprecated since 3.2.0).Spec will be updated separately