Conversation
deepak1556
requested changes
Nov 12, 2025
| } else if constexpr (level == spdlog::level::level_enum::debug) { | ||
| logger_->debug(message); | ||
| } else if constexpr (level == spdlog::level::level_enum::trace) { | ||
| logger_->trace(message); |
Contributor
There was a problem hiding this comment.
Whats the reason for this change ? We still need to initialize the instance method for each of the enum type so there would be no difference between the two approaches https://godbolt.org/z/5xschjrx9
Collaborator
Author
There was a problem hiding this comment.
It was to resolve warning C6326. Let me know if there's another approach I can take.
Contributor
There was a problem hiding this comment.
Okay msvc doesn't optimize for this code https://godbolt.org/z/c84G1E6jb, that's good to know.
deepak1556
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables more flags in accordance with this year's SDL assessment.