Skip to content

Implement async logger creation#4

Merged
sandy081 merged 1 commit intomasterfrom
sandy081/createLoggerAsync
Mar 27, 2019
Merged

Implement async logger creation#4
sandy081 merged 1 commit intomasterfrom
sandy081/createLoggerAsync

Conversation

@sandy081
Copy link
Member

@sandy081 sandy081 commented Mar 27, 2019

Implements #3

  • createRotatingLogger - Creates the logger without checking and creating parent directory. It is required to have parent directory exists.

  • createRotatingLoggerAsync - Creates the logger by checking and creating parent directory

Open to different names for functions

@sandy081 sandy081 requested a review from joaomoreno March 27, 2019 11:03
@sandy081 sandy081 self-assigned this Mar 27, 2019
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@sandy081 sandy081 merged commit 459ea98 into master Mar 27, 2019
@joaomoreno joaomoreno deleted the sandy081/createLoggerAsync branch March 27, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants