fix: CI warnings and 32-bit compile errors#32
Merged
Conversation
deepak1556
requested changes
Apr 4, 2023
Contributor
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
Can you setup Windows 32-bit CI stage in this repo to validate the errors before bringing the change to VSCode.
deepak1556
reviewed
Apr 5, 2023
Skip testing 32-bit because it requires node to also be 32-bit.
deepak1556
reviewed
Apr 6, 2023
Contributor
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
LGTM with minor changes
deepak1556
reviewed
Apr 6, 2023
deepak1556
approved these changes
Apr 7, 2023
TylerLeonhardt
approved these changes
Apr 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some warnings that showed up:
rotating_logger_stthat cause the build to fail for Windows 32-bit.