Conversation
|
Once you have built for electron you need to use |
|
That worked! All the tests are still passing. |
|
In spdlog 1.x calling |
deepak1556
left a comment
There was a problem hiding this comment.
Also needs change to implement the new way of creating async loggers as mentioned by @gabime
|
A few changes
|
|
Due to microsoft/vscode#121852, I'll add another function that creates a synchronous logger during debt week. |
Actually _mt is not required if the sinks are used only in async logger(and as long the thread was pool has single thread). |
This PR updates the spdlog submodule to v1.8.5, and fixes our code where needed.
initThreadPoolmethod rather than asetAsyncModemethod.VoidFormatterhas also changed.Affects microsoft/vscode#121513
I tested my changes by running
npm rebuildand thennpm run testusing node v15.14.0. I did not useelectron-rebuild, because I couldn't find a way to issuenpm run testcommands after running it; I'd get messages likeif I used electron-rebuild or node v14.16.0.
Maybe this means that the
spdlogsubmodule has to somehow be rebuilt with the right version of node, though I'm not sure how.