Skip to content

Merge sources into one repo#329

Merged
andrueastman merged 42 commits intomainfrom
feature/kiota-python
Oct 14, 2024
Merged

Merge sources into one repo#329
andrueastman merged 42 commits intomainfrom
feature/kiota-python

Conversation

@andrueastman
Copy link
Contributor

@andrueastman andrueastman commented Sep 10, 2024 •
edited
Loading

@andrueastman andrueastman mentioned this pull request Sep 13, 2024
Merged
baywet
baywet reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

started reviewing the PR but stopped midway through since I realized #331 still needs to be merged in this branch anyway

@andrueastman
Copy link
Contributor Author

andrueastman commented Sep 24, 2024

started reviewing the PR but stopped midway through since I realized #331 still needs to be merged in this branch anyway

Thanks @baywet, Just to set expectations here, once we close #331, I'll need to make some updates to do the following before this is fully ready for review.

  • Cleanup readmes and related docs
  • Validate workflows
  • Align versioning

@andrueastman andrueastman changed the title WIP: Merge repos into one repo Merge sources into one repo Oct 9, 2024
@andrueastman andrueastman marked this pull request as ready for review October 9, 2024 10:35
@andrueastman andrueastman requested a review from a team as a code owner October 9, 2024 10:35
baywet
baywet previously approved these changes Oct 9, 2024
View reviewed changes
@baywet
Copy link
Member

baywet commented Oct 9, 2024

@andrueastman the policy definition probably needs to be updated here

@andrueastman
Copy link
Contributor Author

andrueastman commented Oct 9, 2024

agreed.
I'll open a sepate PR targeting main in order to close #327 before we merge this.

musale
musale previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @andrueastman!

@baywet
Copy link
Member

baywet commented Oct 11, 2024

this PR also needs to be ported microsoft/kiota-http-python#434

@andrueastman andrueastman dismissed stale reviews from musale and baywet October 14, 2024 08:59

The merge-base changed after approval.

@andrueastman andrueastman mentioned this pull request Oct 14, 2024
Merged
@andrueastman
Copy link
Contributor Author

andrueastman commented Oct 14, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024

Conflicts have been resolved. A maintainer will take a look shortly.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
12 Security Hotspots
17.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@andrueastman andrueastman requested review from baywet and musale October 14, 2024 13:13
@andrueastman
Copy link
Contributor Author

andrueastman commented Oct 14, 2024

This should be good to go with the resolution of #351 and #350

@andrueastman andrueastman merged commit aa37ef4 into main Oct 14, 2024
@andrueastman andrueastman deleted the feature/kiota-python branch October 14, 2024 14:48
@andrueastman andrueastman mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

+1 more reviewer

@musale musale musale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Group python Kiota repositories update CI to create tags on releases based off the changelog

3 participants

@andrueastman @baywet @musale