More fixes to usePressableState#1063
Merged
Saadnajmi merged 3 commits intomicrosoft:masterfrom Oct 14, 2021
Merged
Conversation
rurikoaraki
approved these changes
Oct 14, 2021
This was referenced Oct 14, 2021
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
There are two changes in this PR:
{pressed: true}, and our buttons would be stuck in the pressed state even though they aren't being pressed.onHoverIn/onHoverOut, while mapping it to the Pressable propsonMouseEnter/onMouseLeave. This was done because RN Core doesn't actually expose onHoverIn/onHoverOut yet, which we should fix upstream. Our desktop ports (react-native-macos and react-native-windows) expose the similar props onMouseEnter/onMouseLeave, so we should map to that.Verification
Locally switched some controls (namely button and experimental-button) to use
usePressableStateinstead ofuseAsPressableand verified that the pressed state was getting set correctly.Pull request checklist
This PR has considered (when applicable):