Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for new event types generated by the Azure Functions runtime, specifically handling the translation of SendEntityMessageActions to the older orchestration event protocol by the Durable WebJobs extension.
Key Changes:
- Added support for
orchestratorCompletedandeventSentevent types - Refactored
eventRaisedevent handling to distinguish between entity-related events and regular external events - Introduced
_entity_lock_task_id_mapto track entity lock request task IDs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
durabletask/worker.py
Outdated
| decoded_result = shared.from_json(event.eventRaised.input.value) | ||
| event_list.append(decoded_result) | ||
| # TODO: Investigate why the event result is wrapped in a dict with "result" key | ||
| result = shared.from_json(event.eventRaised.input.value)["result"] |
There was a problem hiding this comment.
Variable result is not used.
Suggested change
| result = shared.from_json(event.eventRaised.input.value)["result"] | |
| pass # result is not used in this block |
berndverst
requested changes
Dec 11, 2025
Member
berndverst
left a comment
berndverst
left a comment
There was a problem hiding this comment.
How about a test that uses the new event types
Contributor
Author
Added |
berndverst
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the new event types generated by the Azure Functions runtime.
Mostly deals with the results of the WebJobs extension translating the SendEntityMessageActions to the older orchestration event protocol
Requires #80 merged first