Merged
Conversation
andystaples
commented
Sep 30, 2025
|
|
||
|
|
||
| class EntityLock: | ||
| # Note: This should |
Contributor
Author
There was a problem hiding this comment.
Will clean this up
Member
There was a problem hiding this comment.
I'll merge - you can clean it up in a follow up PR.
andystaples
commented
Oct 1, 2025
| return self | ||
|
|
||
| def __exit__(self, exc_type, exc_val, exc_tb): | ||
| self._context._exit_critical_section() |
Contributor
Author
There was a problem hiding this comment.
I can do this with a callback, where we just pass the _exit_critical_section method insetad of the whole OrchestrationContext, I just worry if it abstracts things a little too much. Feedback welcome
berndverst
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for durable entities to this SDK
Also fixes a related bug: When the orchestration yields with CompleteOrchestration, we were discarding any pending actions - we need to keep these around for "side effects" actions like unlocking or signaling entities, which the user may expect to complete when the orchestration finishes.
Another issue with the side effects was discovered in the DTS backend, PR is linked in the test comments and the relevant test will need to be re-enabled once the fix is merged.
See the included documentation/samples/tests for usage guidelines.
Reviewers: Request special attention to file structures, naming, docs and tests
Discussion points: