Update the Roslyn to 3.6.0 by Benjie-Liu · Pull Request #786 · microsoft/dotnet-framework-docker

Benjie-Liu · 2021-06-18T09:26:13Z

Fixes #774

Dotnet-GitSync-Bot · 2021-06-18T09:26:16Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

mthalman

In addition to updating the template, the Dockerfiles need to be regenerated from the template. Please read the instructions for updating Dockerfiles.

ghost · 2021-06-22T08:08:10Z

All CLA requirements met.

mthalman · 2021-06-22T13:16:17Z

@Benjie-Liu - Please sign the CLA.

MichaelSimons · 2021-06-22T13:31:32Z

Can updating the https://github.com/microsoft/dotnet-framework-docker/blob/main/.github/ISSUE_TEMPLATE/releases/patch-tuesday-release.md to include a Roslyn update step be included in this PR?

StephenMolloy · 2021-06-23T06:47:15Z

Do we understand the use case of this Roslyn package in our docker containers? This package is from the compiler team... it is not the RoslynCodeDomProvider from the ASP.Net team which would be included as part of the web app being deployed in the container. That package is logically coupled with a particular version of Microsoft.Net.Compilers, which is why its versioning changed in the latest release to reflect the MS.Net.Compilers version it is tied to. In these Dockerfiles, we do set the environment variable that RoslynCodeDomProvider looks for to locate the roslyn tools. So we are effecitvely changing the Roslyn version out from under any app that uses the RoslynCodeDomProvider package, whether they are still on the 2.0.1 train or they have updated to the 3.6 package.

Now, I'm not aware of any compat issues that might arise from using the 2.0.1 RoslynCodeDomProvider package with the 3.6 compilers, or vice versa (3.6 codedom provider with the 2.9 compilers), but we haven't really tested that scenario, and I believe mixing compiler versions with our codedom provider has always been an "at your own risk" sort of thing. With the way we are doing things here, we are most likely creating that situation for folks who aren't paying attention.

mthalman · 2021-06-29T12:52:41Z

@HongGit - Can you comment on the question from @StephenMolloy? It'd be good to have this understood and resolved before next month's release.

Benjie-Liu · 2021-07-02T08:08:54Z

Update the Dockerfiles as Steve and Hong discussed: Keep up the 2.9 compilers as before, add the Roslyn 3.6.0 installation and update the ROSLYN_COMPILER_LOCATION to the latest version C:\RoslynCompilers-3.6.0\tools.

eng/dockerfile-templates/aspnet/Dockerfile.pre20H2

mthalman · 2021-07-02T13:07:01Z

eng/dockerfile-templates/aspnet/Dockerfile

@@ -15,15 +15,24 @@ RUN dism /Online /Quiet /Enable-Feature /All /FeatureName:IIS-WebServerRole {{if
 {{if PRODUCT_VERSION != "3.5"
 :
 # Install Roslyn compilers


# Install 2.9.0 Roslyn compilers

Updated the comments: # Install 2.9.0 Roslyn compilers

mthalman · 2021-07-02T13:07:14Z

eng/dockerfile-templates/aspnet/Dockerfile.pre20H2

@@ -17,17 +17,30 @@ RUN Add-WindowsFeature Web-Server; `

 # Install Roslyn compilers


# Install 2.9.0 Roslyn compilers

MichaelSimons · 2021-07-06T13:04:25Z

As part of this work I would like to see a policy written down for the Roslyn versioning storing. What version(s) will be included and how/when it will get serviced/updated going forward.

mthalman

In addition to the aspnet/Dockerfile template file, the aspnet/Dockerfile.pre20H2 template file also needs to be updated with the same changes.

mthalman · 2021-07-07T13:09:55Z

eng/dockerfile-templates/aspnet/Dockerfile

    && %windir%\Microsoft.NET\Framework64\v4.0.30319\ngen install C:\RoslynCompilers\tools\VBCSCompiler.exe /ExeConfig:C:\RoslynCompilers\tools\VBCSCompiler.exe

-ENV ROSLYN_COMPILER_LOCATION=C:\RoslynCompilers\tools
+# Install 3.6.0 Roslyn compilers 


Remove trailing space at end of line and regenerate affected Dockerfiles.

jaredpar · 2021-07-21T19:39:16Z

eng/dockerfile-templates/aspnet/Dockerfile


-ENV ROSLYN_COMPILER_LOCATION=C:\RoslynCompilers\tools
+# Install 3.6.0 Roslyn compilers
+RUN curl -fSLo microsoft.net.compilers.3.6.0.zip https://api.nuget.org/packages/microsoft.net.compilers.3.6.0.nupkg `


This package is deprecated, please use microsoft.net.compilers.toolset instead

From the NuPkg:

Note: This package is deprecated. Please use Microsoft.Net.Compilers.Toolset instead

Fine for this PR, but in the future we will stop producing new versions of this package.

jaredpar · 2021-07-21T19:41:43Z

So we are effecitvely changing the Roslyn version out from under any app that uses the RoslynCodeDomProvider package, whether they are still on the 2.0.1 train or they have updated to the 3.6 package.

In general that should be fine. The compilers have an incredibly high compatibility bar and our recommendation to customers is always "please upgrade to latest". If you hit errors that would be the rare case, not the norm. Yes changes do exist from version to version but they are generally in decently obscure corner cases

Update the Roslyn to 3.6.0

be1b5a5

Benjie-Liu mentioned this pull request Jun 18, 2021

Consider updating Roslyn binaries #774

Closed

mthalman reviewed Jun 18, 2021

View reviewed changes

[Update the Roslyn version in Dockfiles]

9678aa9

HongGit approved these changes Jun 22, 2021

View reviewed changes

[Add Roslyn 3.6.0 installation]

61f88de

mthalman reviewed Jul 2, 2021

View reviewed changes

StephenMolloy approved these changes Jul 2, 2021

View reviewed changes

update the comments

c66cb2a

mthalman reviewed Jul 6, 2021

View reviewed changes

[Update Dockerfile.per20H2]

7c37781

mthalman reviewed Jul 7, 2021

View reviewed changes

mthalman mentioned this pull request Jul 9, 2021

Define policy for updates to Roslyn version #795

Open

mthalman added 2 commits July 12, 2021 07:51

Remove trailing space

74fe552

Update expected env var value in test

1310fac

mthalman approved these changes Jul 12, 2021

View reviewed changes

mthalman mentioned this pull request Jul 12, 2021

Patch Tuesday Release - 7B #796

Closed

26 tasks

mthalman merged commit 0425e8b into microsoft:main Jul 13, 2021

jaredpar reviewed Jul 21, 2021

View reviewed changes

		@@ -17,17 +17,30 @@ RUN Add-WindowsFeature Web-Server; `

		# Install Roslyn compilers

Conversation

Benjie-Liu commented Jun 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dotnet-GitSync-Bot commented Jun 18, 2021

Uh oh!

mthalman left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Jun 22, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mthalman commented Jun 22, 2021

Uh oh!

MichaelSimons commented Jun 22, 2021

Uh oh!

StephenMolloy commented Jun 23, 2021

Uh oh!

mthalman commented Jun 29, 2021

Uh oh!

Benjie-Liu commented Jul 2, 2021

Uh oh!

Uh oh!

mthalman Jul 2, 2021

Choose a reason for hiding this comment

Uh oh!

Benjie-Liu Jul 6, 2021

Choose a reason for hiding this comment

Uh oh!

mthalman Jul 2, 2021

Choose a reason for hiding this comment

Uh oh!

Benjie-Liu Jul 6, 2021

Choose a reason for hiding this comment

Uh oh!

MichaelSimons commented Jul 6, 2021

Uh oh!

mthalman left a comment

Choose a reason for hiding this comment

Uh oh!

mthalman Jul 7, 2021

Choose a reason for hiding this comment

Uh oh!

jaredpar Jul 21, 2021

Choose a reason for hiding this comment

Uh oh!

jaredpar Jul 21, 2021

Choose a reason for hiding this comment

Uh oh!

jaredpar commented Jul 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Benjie-Liu commented Jun 18, 2021 •

edited

Loading

ghost commented Jun 22, 2021 •

edited by ghost

Loading