[DO NOT MERGE] Use builtin stash and rebase

[derrickstolee]

This is only to run the functional tests with the builtin rebase and stash.

[sanoursa]

@derrickstolee thanks for kicking this off. The big repo perf tests would also be useful, so we can give folks guidance on whether it even makes sense to turn these settings on.

[derrickstolee]

Windows Functional Tests that broke are related to error messages:

1) Failed : GVFS.FunctionalTests.Tests.GitCommands.GitCommandsTests.StashChanges()
stash Output Lines
Extra: Saved working directory and index state WIP on StashChanges: b76df49a1e02465ef1c27d9c2a1720b337de99c8 Add test files for enumeration with restart scans
Missing: Saved working directory and index state WIP on tests/functional/StashChanges: b76df49a1e02465ef1c27d9c2a1720b337de99c8 Add test files for enumeration with restart scans
   at GVFS.Tests.Should.EnumerableShouldExtensions.ShouldMatchInOrder[T](IEnumerable`1 group, IEnumerable`1 expectedValues, Func`3 equals, String message) in C:\agent\_work\11\s\GVFS\GVFS.Tests\Should\EnumerableShouldExtensions.cs:line 119
   at GVFS.FunctionalTests.Tools.GitHelpers.ValidateGitCommand(GVFSFunctionalTestEnlistment enlistment, ControlGitRepo controlGitRepo, String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 91
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateGitCommand(String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 180
   at GVFS.FunctionalTests.Tests.GitCommands.GitCommandsTests.StashChanges() in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitCommandsTests.cs:line 938

2) Failed : GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseDirectoryWithOneFile()
rebase FunctionalTests/20171025_DirectoryWithDifferentFile Errors Lines
rebase FunctionalTests/20171025_DirectoryWithDifferentFile Errors Lines counts do not match. was: 1 expected: 2
Extra: fatal: invalid upstream 'FunctionalTests/20171025_DirectoryWithDifferentFile'
Missing: fatal: Needed a single revision
Missing: invalid upstream 'FunctionalTests/20171025_DirectoryWithDifferentFile'
   at GVFS.Tests.Should.EnumerableShouldExtensions.ShouldMatchInOrder[T](IEnumerable`1 group, IEnumerable`1 expectedValues, Func`3 equals, String message) in C:\agent\_work\11\s\GVFS\GVFS.Tests\Should\EnumerableShouldExtensions.cs:line 119
   at GVFS.FunctionalTests.Tools.GitHelpers.ErrorsShouldMatch(String command, ProcessResult expectedResult, ProcessResult actualResult) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 139
   at GVFS.FunctionalTests.Tools.GitHelpers.ValidateGitCommand(GVFSFunctionalTestEnlistment enlistment, ControlGitRepo controlGitRepo, String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 90
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateGitCommand(String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 180
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateFileDirectoryTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 392
   at GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseDirectoryWithOneFile() in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\RebaseTests.cs:line 95

3) Failed : GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseDirectoryWithOneFileEnumerate()
rebase FunctionalTests/20171025_DirectoryWithDifferentFile Errors Lines
rebase FunctionalTests/20171025_DirectoryWithDifferentFile Errors Lines counts do not match. was: 1 expected: 2
Extra: fatal: invalid upstream 'FunctionalTests/20171025_DirectoryWithDifferentFile'
Missing: fatal: Needed a single revision
Missing: invalid upstream 'FunctionalTests/20171025_DirectoryWithDifferentFile'
   at GVFS.Tests.Should.EnumerableShouldExtensions.ShouldMatchInOrder[T](IEnumerable`1 group, IEnumerable`1 expectedValues, Func`3 equals, String message) in C:\agent\_work\11\s\GVFS\GVFS.Tests\Should\EnumerableShouldExtensions.cs:line 119
   at GVFS.FunctionalTests.Tools.GitHelpers.ErrorsShouldMatch(String command, ProcessResult expectedResult, ProcessResult actualResult) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 139
   at GVFS.FunctionalTests.Tools.GitHelpers.ValidateGitCommand(GVFSFunctionalTestEnlistment enlistment, ControlGitRepo controlGitRepo, String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 90
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateGitCommand(String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 180
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateFileDirectoryTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 392
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.RunFileDirectoryEnumerateTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 402
   at GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseDirectoryWithOneFileEnumerate() in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\RebaseTests.cs:line 101

4) Failed : GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseDirectoryWithOneFileRead()
rebase FunctionalTests/20171025_DirectoryWithDifferentFile Errors Lines
rebase FunctionalTests/20171025_DirectoryWithDifferentFile Errors Lines counts do not match. was: 1 expected: 2
Extra: fatal: invalid upstream 'FunctionalTests/20171025_DirectoryWithDifferentFile'
Missing: fatal: Needed a single revision
Missing: invalid upstream 'FunctionalTests/20171025_DirectoryWithDifferentFile'
   at GVFS.Tests.Should.EnumerableShouldExtensions.ShouldMatchInOrder[T](IEnumerable`1 group, IEnumerable`1 expectedValues, Func`3 equals, String message) in C:\agent\_work\11\s\GVFS\GVFS.Tests\Should\EnumerableShouldExtensions.cs:line 119
   at GVFS.FunctionalTests.Tools.GitHelpers.ErrorsShouldMatch(String command, ProcessResult expectedResult, ProcessResult actualResult) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 139
   at GVFS.FunctionalTests.Tools.GitHelpers.ValidateGitCommand(GVFSFunctionalTestEnlistment enlistment, ControlGitRepo controlGitRepo, String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 90
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateGitCommand(String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 180
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateFileDirectoryTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 392
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.RunFileDirectoryReadTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 409
   at GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseDirectoryWithOneFileRead() in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\RebaseTests.cs:line 107

5) Failed : GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseDirectoryWithOneFileWrite()
rebase FunctionalTests/20171025_DirectoryWithDifferentFile Errors Lines
rebase FunctionalTests/20171025_DirectoryWithDifferentFile Errors Lines counts do not match. was: 1 expected: 2
Extra: fatal: invalid upstream 'FunctionalTests/20171025_DirectoryWithDifferentFile'
Missing: fatal: Needed a single revision
Missing: invalid upstream 'FunctionalTests/20171025_DirectoryWithDifferentFile'
   at GVFS.Tests.Should.EnumerableShouldExtensions.ShouldMatchInOrder[T](IEnumerable`1 group, IEnumerable`1 expectedValues, Func`3 equals, String message) in C:\agent\_work\11\s\GVFS\GVFS.Tests\Should\EnumerableShouldExtensions.cs:line 119
   at GVFS.FunctionalTests.Tools.GitHelpers.ErrorsShouldMatch(String command, ProcessResult expectedResult, ProcessResult actualResult) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 139
   at GVFS.FunctionalTests.Tools.GitHelpers.ValidateGitCommand(GVFSFunctionalTestEnlistment enlistment, ControlGitRepo controlGitRepo, String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 90
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateGitCommand(String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 180
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateFileDirectoryTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 392
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.RunFileDirectoryWriteTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 416
   at GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseDirectoryWithOneFileWrite() in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\RebaseTests.cs:line 113

6) Failed : GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseSmallOneFileConflict()
rebase 99fc72275f950b0052c8548bbcf83a851f2b4467 Errors Lines
rebase 99fc72275f950b0052c8548bbcf83a851f2b4467 Errors Lines counts do not match. was: 1 expected: 2
Extra: fatal: invalid upstream '99fc72275f950b0052c8548bbcf83a851f2b4467'
Missing: fatal: Needed a single revision
Missing: invalid upstream '99fc72275f950b0052c8548bbcf83a851f2b4467'
   at GVFS.Tests.Should.EnumerableShouldExtensions.ShouldMatchInOrder[T](IEnumerable`1 group, IEnumerable`1 expectedValues, Func`3 equals, String message) in C:\agent\_work\11\s\GVFS\GVFS.Tests\Should\EnumerableShouldExtensions.cs:line 119
   at GVFS.FunctionalTests.Tools.GitHelpers.ErrorsShouldMatch(String command, ProcessResult expectedResult, ProcessResult actualResult) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 139
   at GVFS.FunctionalTests.Tools.GitHelpers.ValidateGitCommand(GVFSFunctionalTestEnlistment enlistment, ControlGitRepo controlGitRepo, String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 90
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateGitCommand(String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 180
   at GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseSmallOneFileConflict() in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\RebaseTests.cs:line 45

7) Failed : GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseWithDirectoryNameSameAsFile()
rebase FunctionalTests/20171025_DirectoryWithFileAfter Errors Lines
rebase FunctionalTests/20171025_DirectoryWithFileAfter Errors Lines counts do not match. was: 1 expected: 2
Extra: fatal: invalid upstream 'FunctionalTests/20171025_DirectoryWithFileAfter'
Missing: fatal: Needed a single revision
Missing: invalid upstream 'FunctionalTests/20171025_DirectoryWithFileAfter'
   at GVFS.Tests.Should.EnumerableShouldExtensions.ShouldMatchInOrder[T](IEnumerable`1 group, IEnumerable`1 expectedValues, Func`3 equals, String message) in C:\agent\_work\11\s\GVFS\GVFS.Tests\Should\EnumerableShouldExtensions.cs:line 119
   at GVFS.FunctionalTests.Tools.GitHelpers.ErrorsShouldMatch(String command, ProcessResult expectedResult, ProcessResult actualResult) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 139
   at GVFS.FunctionalTests.Tools.GitHelpers.ValidateGitCommand(GVFSFunctionalTestEnlistment enlistment, ControlGitRepo controlGitRepo, String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 90
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateGitCommand(String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 180
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateFileDirectoryTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 392
   at GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseWithDirectoryNameSameAsFile() in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\RebaseTests.cs:line 70

8) Failed : GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseWithDirectoryNameSameAsFileEnumerate()
rebase FunctionalTests/20171025_DirectoryWithFileAfter Errors Lines
rebase FunctionalTests/20171025_DirectoryWithFileAfter Errors Lines counts do not match. was: 1 expected: 2
Extra: fatal: invalid upstream 'FunctionalTests/20171025_DirectoryWithFileAfter'
Missing: fatal: Needed a single revision
Missing: invalid upstream 'FunctionalTests/20171025_DirectoryWithFileAfter'
   at GVFS.Tests.Should.EnumerableShouldExtensions.ShouldMatchInOrder[T](IEnumerable`1 group, IEnumerable`1 expectedValues, Func`3 equals, String message) in C:\agent\_work\11\s\GVFS\GVFS.Tests\Should\EnumerableShouldExtensions.cs:line 119
   at GVFS.FunctionalTests.Tools.GitHelpers.ErrorsShouldMatch(String command, ProcessResult expectedResult, ProcessResult actualResult) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 139
   at GVFS.FunctionalTests.Tools.GitHelpers.ValidateGitCommand(GVFSFunctionalTestEnlistment enlistment, ControlGitRepo controlGitRepo, String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 90
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateGitCommand(String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 180
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateFileDirectoryTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 392
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.RunFileDirectoryEnumerateTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 402
   at GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseWithDirectoryNameSameAsFileEnumerate() in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\RebaseTests.cs:line 76

9) Failed : GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseWithDirectoryNameSameAsFileWithRead()
rebase FunctionalTests/20171025_DirectoryWithFileAfter Errors Lines
rebase FunctionalTests/20171025_DirectoryWithFileAfter Errors Lines counts do not match. was: 1 expected: 2
Extra: fatal: invalid upstream 'FunctionalTests/20171025_DirectoryWithFileAfter'
Missing: fatal: Needed a single revision
Missing: invalid upstream 'FunctionalTests/20171025_DirectoryWithFileAfter'
   at GVFS.Tests.Should.EnumerableShouldExtensions.ShouldMatchInOrder[T](IEnumerable`1 group, IEnumerable`1 expectedValues, Func`3 equals, String message) in C:\agent\_work\11\s\GVFS\GVFS.Tests\Should\EnumerableShouldExtensions.cs:line 119
   at GVFS.FunctionalTests.Tools.GitHelpers.ErrorsShouldMatch(String command, ProcessResult expectedResult, ProcessResult actualResult) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 139
   at GVFS.FunctionalTests.Tools.GitHelpers.ValidateGitCommand(GVFSFunctionalTestEnlistment enlistment, ControlGitRepo controlGitRepo, String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 90
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateGitCommand(String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 180
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateFileDirectoryTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 392
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.RunFileDirectoryReadTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 409
   at GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseWithDirectoryNameSameAsFileWithRead() in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\RebaseTests.cs:line 82

10) Failed : GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseWithDirectoryNameSameAsFileWithWrite()
rebase FunctionalTests/20171025_DirectoryWithFileAfter Errors Lines
rebase FunctionalTests/20171025_DirectoryWithFileAfter Errors Lines counts do not match. was: 1 expected: 2
Extra: fatal: invalid upstream 'FunctionalTests/20171025_DirectoryWithFileAfter'
Missing: fatal: Needed a single revision
Missing: invalid upstream 'FunctionalTests/20171025_DirectoryWithFileAfter'
   at GVFS.Tests.Should.EnumerableShouldExtensions.ShouldMatchInOrder[T](IEnumerable`1 group, IEnumerable`1 expectedValues, Func`3 equals, String message) in C:\agent\_work\11\s\GVFS\GVFS.Tests\Should\EnumerableShouldExtensions.cs:line 119
   at GVFS.FunctionalTests.Tools.GitHelpers.ErrorsShouldMatch(String command, ProcessResult expectedResult, ProcessResult actualResult) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 139
   at GVFS.FunctionalTests.Tools.GitHelpers.ValidateGitCommand(GVFSFunctionalTestEnlistment enlistment, ControlGitRepo controlGitRepo, String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tools\GitHelpers.cs:line 90
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateGitCommand(String command, Object[] args) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 180
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.ValidateFileDirectoryTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 392
   at GVFS.FunctionalTests.Tests.GitCommands.GitRepoTests.RunFileDirectoryWriteTest(String command, String commandBranch) in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\GitRepoTests.cs:line 416
   at GVFS.FunctionalTests.Tests.GitCommands.RebaseTests.RebaseWithDirectoryNameSameAsFileWithWrite() in C:\agent\_work\11\s\GVFS\GVFS.FunctionalTests\Tests\GitCommands\RebaseTests.cs:line 88

[derrickstolee]

The Full Functional Tests have the same failures.

[kewillford]

You will need to turn on these options for the control repo as well so that it will be using the builtins as well and we will be comparing builtin rebase on the VFS repo with the builtin rebase on the control repo. Right now this is comparing running the builtin rebase on the VFS repo but the script on the control repo which is probably why the messages don't match.