Mac kext: Adds check to only handle fileops on allowed filesystems#352
Merged
pmj merged 1 commit intomicrosoft:masterfrom Oct 7, 2018
Merged
Mac kext: Adds check to only handle fileops on allowed filesystems#352pmj merged 1 commit intomicrosoft:masterfrom
pmj merged 1 commit intomicrosoft:masterfrom
Conversation
The vnode handler was already performing this check, but the fileop handler previously skipped it. This is part 1 of a fix for KP bug report microsoft#340.
sanoursa
approved these changes
Oct 6, 2018
nickgra
approved these changes
Oct 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vnode handler was already performing this check, but the fileop handler previously skipped it. This means we were running our logic and vnode I/O on files that weren't on a supported file system.
This is part 1 of a fix for KP bug report #340. Potentially also removes some sources of I/O errors causing failed assertions (#328).